NFS3 protocol specific snapshot workflows by rajiv-jain-netapp · Pull Request #36 · NetApp/cloudstack

rajiv-jain-netapp · 2026-02-20T06:30:49Z

Description

This PR...

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

rajiv-jain-netapp · 2026-02-20T06:31:03Z

I have tested

Taking a CS-volume snapshot for the data CS-volume.
Tried to take VM-level snapshot, CloudStack asked me to select a single CS-volume instead of allowing to take a VM-level snapshot. That also worked.

…iecing is enabled and memory-disk is opted out

rajiv-jain-netapp · 2026-02-21T11:18:03Z

I have tested VM level and cloudstack-volume level snapshots, all found working

VM level snapshot without memory-disk and quiecing option.
VM level snapshot with quiecing option enabled. --> did not find working and error says, unable to quiece VM since emu agent is not found working on VM
VM level snapshot with memory snapshot enabled--> working
VM level snapshot with memory-snapshot and quiecing options enabled --> working fine.
cloudstack volume level snapshots are working fine.

...ain/java/org/apache/cloudstack/storage/vmsnapshot/KvmFileBasedStorageVmSnapshotStrategy.java

suryag1201 · 2026-02-23T17:27:54Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java


    @Override
    public void takeSnapshot(SnapshotInfo snapshot, AsyncCompletionCallback<CreateCmdResult> callback) {
+        s_logger.error("temp takeSnapshot : entered with snapshot id: " + snapshot.getId() + " and name: " + snapshot.getName());


log level should not be error plus remove temp

Yes, this was intentionally kept for testing and was mistakenly overlooked during cleanup.

suryag1201 · 2026-02-23T17:29:17Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+            Map<String, String> poolDetails = storagePoolDetailsDao.listDetailsKeyPairs(volumeVO.getPoolId());
+            StorageStrategy storageStrategy = Utility.getStrategyByStoragePoolDetails(poolDetails);
+
+            Map<String, String> cloudStackVolumeRequestMap = new HashMap<>();


Get Volume Request is not as per protocol

added protocol check.

suryag1201 · 2026-02-23T17:30:58Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+            cloudStackVolumeRequestMap.put(Constants.VOLUME_UUID, poolDetails.get(Constants.VOLUME_UUID));
+            cloudStackVolumeRequestMap.put(Constants.FILE_PATH, volumeVO.getPath());
+            CloudStackVolume cloudStackVolume = storageStrategy.getCloudStackVolume(cloudStackVolumeRequestMap);
+            if (cloudStackVolume == null || cloudStackVolume.getFile() == null) {


this condition is also specific to file, it will fail for lun

suryag1201 · 2026-02-23T17:31:25Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+                throw new CloudRuntimeException("takeSnapshot: Failed to get source file to take snapshot");
+            }
+            long capacityBytes = storagePool.getCapacityBytes();
+            s_logger.error("temp takeSnapshot : entered after getting cloudstack volume with file path: " + cloudStackVolume.getFile().getPath() + " and size: " + cloudStackVolume.getFile().getSize());


log level should not be error

suryag1201 · 2026-02-23T17:32:04Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+            long capacityBytes = storagePool.getCapacityBytes();
+            s_logger.error("temp takeSnapshot : entered after getting cloudstack volume with file path: " + cloudStackVolume.getFile().getPath() + " and size: " + cloudStackVolume.getFile().getSize());
+            long usedBytes = getUsedBytes(storagePool);
+            long fileSize = cloudStackVolume.getFile().getSize();


these all changes are related to file

suryag1201 · 2026-02-23T17:32:40Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+
+            String fileSnapshotName = volumeInfo.getName() + "-" + snapshot.getUuid();

+            int maxSnapshotNameLength = 64;


I think, we can have more character in snapshot name

moved it to contants for now, will update the length by checking it, if required.

suryag1201 · 2026-02-23T17:33:44Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+        return cloudStackVolumeRequest;
+    }
+
+    private CloudStackVolume snapshotCloudStackVolumeRequestByProtocol(Map<String, String> details,


this method is not used anywhere

I am calling this method in takeSnapshot()

...volume/ontap/src/main/java/org/apache/cloudstack/storage/service/model/CloudStackVolume.java

rajiv-jain-netapp

reposting the PR with changes

...ain/java/org/apache/cloudstack/storage/vmsnapshot/KvmFileBasedStorageVmSnapshotStrategy.java

rajiv-jain-netapp · 2026-02-24T03:59:27Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java


    @Override
    public void takeSnapshot(SnapshotInfo snapshot, AsyncCompletionCallback<CreateCmdResult> callback) {
+        s_logger.error("temp takeSnapshot : entered with snapshot id: " + snapshot.getId() + " and name: " + snapshot.getName());


Yes, this was intentionally kept for testing and was mistakenly overlooked during cleanup.

rajiv-jain-netapp · 2026-02-24T04:06:37Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+            Map<String, String> poolDetails = storagePoolDetailsDao.listDetailsKeyPairs(volumeVO.getPoolId());
+            StorageStrategy storageStrategy = Utility.getStrategyByStoragePoolDetails(poolDetails);
+
+            Map<String, String> cloudStackVolumeRequestMap = new HashMap<>();


added protocol check.

rajiv-jain-netapp · 2026-02-24T04:06:49Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+            cloudStackVolumeRequestMap.put(Constants.VOLUME_UUID, poolDetails.get(Constants.VOLUME_UUID));
+            cloudStackVolumeRequestMap.put(Constants.FILE_PATH, volumeVO.getPath());
+            CloudStackVolume cloudStackVolume = storageStrategy.getCloudStackVolume(cloudStackVolumeRequestMap);
+            if (cloudStackVolume == null || cloudStackVolume.getFile() == null) {


rajiv-jain-netapp · 2026-02-24T04:06:59Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+                throw new CloudRuntimeException("takeSnapshot: Failed to get source file to take snapshot");
+            }
+            long capacityBytes = storagePool.getCapacityBytes();
+            s_logger.error("temp takeSnapshot : entered after getting cloudstack volume with file path: " + cloudStackVolume.getFile().getPath() + " and size: " + cloudStackVolume.getFile().getSize());


rajiv-jain-netapp · 2026-02-24T04:12:14Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+            long capacityBytes = storagePool.getCapacityBytes();
+            s_logger.error("temp takeSnapshot : entered after getting cloudstack volume with file path: " + cloudStackVolume.getFile().getPath() + " and size: " + cloudStackVolume.getFile().getSize());
+            long usedBytes = getUsedBytes(storagePool);
+            long fileSize = cloudStackVolume.getFile().getSize();


rajiv-jain-netapp · 2026-02-24T04:13:26Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+
+            String fileSnapshotName = volumeInfo.getName() + "-" + snapshot.getUuid();

+            int maxSnapshotNameLength = 64;


moved it to contants for now, will update the length by checking it, if required.

rajiv-jain-netapp · 2026-02-24T04:15:05Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+        return cloudStackVolumeRequest;
+    }
+
+    private CloudStackVolume snapshotCloudStackVolumeRequestByProtocol(Map<String, String> details,


I am calling this method in takeSnapshot()

...volume/ontap/src/main/java/org/apache/cloudstack/storage/service/model/CloudStackVolume.java

piyush5netapp · 2026-02-24T05:02:20Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

-        mapCapabilities.put(DataStoreCapabilities.STORAGE_SYSTEM_SNAPSHOT.toString(), Boolean.FALSE.toString());
-        mapCapabilities.put(DataStoreCapabilities.CAN_CREATE_VOLUME_FROM_SNAPSHOT.toString(), Boolean.FALSE.toString());
+        mapCapabilities.put(DataStoreCapabilities.STORAGE_SYSTEM_SNAPSHOT.toString(), Boolean.TRUE.toString());
+        mapCapabilities.put(DataStoreCapabilities.CAN_CREATE_VOLUME_FROM_SNAPSHOT.toString(), Boolean.TRUE.toString());


Why do we need to set this as true as we are currently not supporting volume creation from snapshot.

Without this property set to true, CloudStack initiates both the snapshot creation and the corresponding copy operation to secondary storage over the data path, as it assumes that snapshots must reside on secondary storage by default.
When only the storage-system-snapshot property is enabled, CloudStack successfully invokes the takeSnapshot() method in the plugin driver class. However, the snapshot remains on the primary storage pool and is not transferred to secondary storage.

So, with this implementation, snapshots reside in primary storage itself?

What I’m trying to explain is that if we don’t keep the second flag set to true, then only the plugin‑created snapshot will remain on the primary. In that case, the orchestrator will call the host agent again to create another snapshot and copy it to the secondary.
To avoid this unnecessary duplicate operation, I set both flags to true. This ensures that the orchestrator does not rely on the host-agent portion of the workflow, and the snapshot created by the plugin is the one that gets copied to the secondary.

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

sandeeplocharla · 2026-02-24T04:48:15Z

...com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCreateDiskOnlyVMSnapshotCommandWrapper.java

        return new Pair<>(snapshotXml, volumeObjectToNewPathMap);
    }

+    protected void cleanupLeftoverDeltas(List<VolumeObjectTO> volumeObjectTos, Map<String, Pair<Long, String>> mapVolumeToSnapshotSizeAndNewVolumePath, KVMStoragePoolManager storagePoolMgr) {


Does this refactoring somehow help our plugin functionality?

sandeeplocharla · 2026-02-24T04:48:59Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

-        mapCapabilities.put(DataStoreCapabilities.STORAGE_SYSTEM_SNAPSHOT.toString(), Boolean.FALSE.toString());
-        mapCapabilities.put(DataStoreCapabilities.CAN_CREATE_VOLUME_FROM_SNAPSHOT.toString(), Boolean.FALSE.toString());
+        mapCapabilities.put(DataStoreCapabilities.STORAGE_SYSTEM_SNAPSHOT.toString(), Boolean.TRUE.toString());
+        mapCapabilities.put(DataStoreCapabilities.CAN_CREATE_VOLUME_FROM_SNAPSHOT.toString(), Boolean.TRUE.toString());


We are supporting volume creation from snapshot with this PR?

volume creation usecase is not yet ready as part of this PR

sandeeplocharla · 2026-02-24T04:50:17Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java


    @Override
    public void takeSnapshot(SnapshotInfo snapshot, AsyncCompletionCallback<CreateCmdResult> callback) {
+        s_logger.info("takeSnapshot : entered with snapshot id: " + snapshot.getId() + " and name: " + snapshot.getName());


Lets have an intuitive log message instead of a method entry logger?

Could you provide a few examples?
Since I am also logging the method arguments, I felt that this approach would give me better insight into the method invocation flow, rather than relying solely on static logging.

Instead of adding an entry log we can add a log post line 544. For example, it could be like
s_logger.info("takeSnapshot: Snapshot with ID: " + snapshot.getId() + " and name: " + snapshot.getName() + " requested for volume with ID: " + volumeVO.getId() + " and name: " + volumeVO.getName())
It's just an example but I feel this could give us more outlook on whats happening.

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

sandeeplocharla · 2026-02-24T04:55:57Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+                cloudStackVolumeRequestMap.put(Constants.FILE_PATH, volumeVO.getPath());
+                cloudStackVolume = storageStrategy.getCloudStackVolume(cloudStackVolumeRequestMap);
+                if (cloudStackVolume == null || cloudStackVolume.getFile() == null) {
+                    throw new CloudRuntimeException("takeSnapshot: Failed to get source file to take snapshot");


Should we have method names only in loggers and not have them in exceptions? Management server might show this as an error on the UI?

acknowledged

sandeeplocharla · 2026-02-24T05:49:23Z

...age/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedNASStrategy.java

+        try {
+            fileResponse = nasFeignClient.getFileResponse(authHeader, volumeUuid, filePath);
+            if (fileResponse == null || fileResponse.getRecords().isEmpty()) {
+                throw new CloudRuntimeException("File " + filePath + " not not found on ONTAP. " +


Typo "not not"

Still see the same

...me/ontap/src/main/java/org/apache/cloudstack/storage/vmsnapshot/OntapVMSnapshotStrategy.java

sandeeplocharla · 2026-02-24T05:56:20Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/vmsnapshot/OntapVMSnapshotStrategy.java

+            return false;
+        }
+
+        if (!Hypervisor.HypervisorType.KVM.equals(userVm.getHypervisorType())) {


We already have checks in StoragePool and CS Volume creation workflows for Hypervisor type right? Do we need it here also?

This is inline with the snapshot workflow

sandeeplocharla · 2026-02-24T05:57:48Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/vmsnapshot/OntapVMSnapshotStrategy.java

+            return false;
+        }
+
+        if (!VirtualMachine.State.Running.equals(userVm.getState())) {


Wouldn't this block disk snapshots?

...me/ontap/src/main/java/org/apache/cloudstack/storage/vmsnapshot/OntapVMSnapshotStrategy.java

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

piyush5netapp · 2026-02-24T10:44:26Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+
+            updateSnapshotDetails(snapshot.getId(), volumeInfo.getId(), poolDetails.get(Constants.VOLUME_UUID), cloneCloudStackVolume.getFile().getPath(), volumeVO.getPoolId(), fileSize);
+
+            snapshotObjectTo.setPath(Constants.ONTAP_SNAP_ID +"="+cloneCloudStackVolume.getFile().getPath());


Is "=" intentional ?

sandeeplocharla · 2026-02-24T11:16:34Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+            CloudStackVolume snapCloudStackVolumeRequest = snapshotCloudStackVolumeRequestByProtocol(poolDetails, volumeVO.getPath(), snapshotName);
+            CloudStackVolume cloneCloudStackVolume = storageStrategy.snapshotCloudStackVolume(snapCloudStackVolumeRequest);
+
+            updateSnapshotDetails(snapshot.getId(), volumeInfo.getId(), poolDetails.get(Constants.VOLUME_UUID), cloneCloudStackVolume.getFile().getPath(), volumeVO.getPoolId(), fileSize);


If iSCSI needs different things to be updated in DB, we might get an if-else on protocol here also.

yes, we have to handle that with iscsi protocol.

piyush5netapp · 2026-02-24T11:55:50Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/vmsnapshot/OntapVMSnapshotStrategy.java

+            if (volume.getPoolId() == null) {
+                return false;
+            }
+            StoragePoolVO pool = storagePool.findById(volume.getPoolId());


We can optimize here -> Instead of making findById for each volume, we can use listByUuids by passing all volumes together. This will save much db calls and memory.

DB calls are local and not very expensive.

piyush5netapp · 2026-02-24T11:59:45Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/vmsnapshot/OntapVMSnapshotStrategy.java

+            boolean quiescevm = true;
+            VMSnapshotOptions options = vmSnapshotVO.getOptions();
+            if (options != null && !options.needQuiesceVM()) {
+                logger.info("Quiesce option was set to false, but overriding to true for ONTAP managed storage " +


If we are planning to only support app consistency, why not throw an error message stating ONTAP recommends quiescing the vm instead of overriding in backend without notifying user.

Logic has been changed to adhering the user input on quiecing

…evel snapshot

…ge level support.

…ustomized class only.

…r vm snapshots

…workflow

…shot with driver orchestrator workflow

… agent path

…stopped state both.

… now

piyush5netapp · 2026-03-09T05:42:40Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

-        // TODO Set it to false once we start supporting snapshot feature
-        mapCapabilities.put(DataStoreCapabilities.STORAGE_SYSTEM_SNAPSHOT.toString(), Boolean.FALSE.toString());
-        mapCapabilities.put(DataStoreCapabilities.CAN_CREATE_VOLUME_FROM_SNAPSHOT.toString(), Boolean.FALSE.toString());
+        // STORAGE_SYSTEM_SNAPSHOT=TRUE enables StorageSystemSnapshotStrategy to handle snapshots.


Please remove comments if applicable

piyush5netapp · 2026-03-09T05:42:58Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

        }
    }

+    /**


same as above

these commented code was left in earlier merges, I will remove it.

piyush5netapp · 2026-03-09T05:51:26Z

...n/resources/META-INF/cloudstack/storage-volume-ontap/spring-storage-volume-ontap-context.xml

    <bean id="ontapPrimaryDataStoreProvider"
        class="org.apache.cloudstack.storage.provider.OntapPrimaryDatastoreProvider" />

+    <bean id="ontapVMSnapshotStrategy"


Why not inject it through configure method of OntapPrimaryDatastoreProvider which will also follow cloudstack injection framework.

this change is for context to be given tot he cloudstack for the classes we added and we want them to be loaded in the JVM

I think that way also , it will give context to the cloudstack and will be loaded in JVM once ontap driver is loaded.

piyush5netapp · 2026-03-09T05:56:19Z

...age/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedSANStrategy.java

        this.sanFeignClient = feignClientFactory.createClient(SANFeignClient.class, baseURL);
    }

+    @Override


why do we need this here again? We already have sanFeignClient in it constructor.

right, corrected it now

piyush5netapp · 2026-03-09T06:06:55Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+            SnapshotObjectTO snapshotObjectTo = (SnapshotObjectTO) snapshot.getTO();
+
+            // Build snapshot name using volume name and snapshot UUID
+            String snapshotName = buildSnapshotCloneName(volumeInfo.getName(), snapshot.getUuid());


It is just a method name, but corrected.

If you notice, it is just a method name. But I will update this.

suryag1201

comments resolved

sandeeplocharla · 2026-03-09T06:00:30Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+
+            VolumeVO volumeVO = volumeDao.findById(volumeInfo.getId());
+            if (volumeVO == null) {
+                throw new CloudRuntimeException("takeSnapshot: VolumeVO not found for id: " + volumeInfo.getId());


Please don't add method names in exceptions, as we don't have any cleanup framework before showing them on UI

I understand. I was watching such instances, some of which are still overlooked.

sandeeplocharla · 2026-03-09T06:11:31Z

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java

+     */
    @Override
-    public void revertSnapshot(SnapshotInfo snapshotOnImageStore, SnapshotInfo snapshotOnPrimaryStore, AsyncCompletionCallback<CommandResult> callback) {
+    public void revertSnapshot(SnapshotInfo snapshotOnImageStore, SnapshotInfo snapshotOnPrimaryStore,


I see that 'CAN_CREATE_VOLUME_FROM_SNAPSHOT' in the capabilities list has been set to 'True', but createAsync doesn't have any implementation to create volume from snapshot. So, if we are not supporting creating volume from snapshot, do we need revertSnapshot implementation?

We’ve made good progress on the revert while working in parallel on the snapshot design, since both need to align. Our first PR is still awaiting community review, which is giving us additional time to advance the revert work. I plan to finalize the revert workflow once we complete the upcoming planned milestone. If time permits, the goal is to include the revert changes in the next PR as well.

piyush5netapp

Please add testing screenshot .

rajiv-jain-netapp added 3 commits February 19, 2026 19:53

CSTACKEX-18_2: NFS3 snapshot changes

f42552b

CSTACK-18_2: fixing junit dependent changes

8894248

STACK-18_2: fixes

3f0019a

rajiv-jain-netapp added 4 commits February 20, 2026 14:12

CSTACKEX-18_2: adding VM snapshot logic

9b79f46

CSTACKEX-18_2: fix junit issues

7a0d61e

CSTACKEX-18_2: fixes for vm snapshot workflow

7c3419e

CSTACKEX-18_2: fixing the behaviour for the VM level snapshot when qu…

d2b6a27

…iecing is enabled and memory-disk is opted out

suryag1201 reviewed Feb 23, 2026

View reviewed changes

...ain/java/org/apache/cloudstack/storage/vmsnapshot/KvmFileBasedStorageVmSnapshotStrategy.java Show resolved Hide resolved

suryag1201 reviewed Feb 23, 2026

View reviewed changes

...volume/ontap/src/main/java/org/apache/cloudstack/storage/service/model/CloudStackVolume.java Show resolved Hide resolved

suryag1201 requested changes Feb 23, 2026

View reviewed changes

rajiv-jain-netapp commented Feb 24, 2026

View reviewed changes

rajiv-jain-netapp added 2 commits February 24, 2026 09:49

CSTACKEX-18_2: incorporating the review comments.

c5d5428

CSTACKEX-18_2: transient fixes post incorporating the comments

3f18c11

piyush5netapp reviewed Feb 24, 2026

View reviewed changes

sandeeplocharla reviewed Feb 24, 2026

View reviewed changes

piyush5netapp reviewed Feb 24, 2026

View reviewed changes

...me/ontap/src/main/java/org/apache/cloudstack/storage/vmsnapshot/OntapVMSnapshotStrategy.java Show resolved Hide resolved

CSTACKEX-18_2: Incorporate review comments

723561b

piyush5netapp reviewed Feb 24, 2026

View reviewed changes

...me/ontap/src/main/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriver.java Show resolved Hide resolved

piyush5netapp reviewed Feb 24, 2026

View reviewed changes

sandeeplocharla reviewed Feb 24, 2026

View reviewed changes

piyush5netapp reviewed Feb 24, 2026

View reviewed changes

rajiv-jain-netapp added 20 commits February 25, 2026 15:37

CSTACKEX-18_2: quiecing VM would be done based on user input for VM l…

09968db

…evel snapshot

CSTACKEX-18_2: ONTAP plugin can not handle memory snapshot with stora…

0a1a9c4

…ge level support.

CSTACKEX-18_2: junit fix

49df4c3

CSTACKEX-18_2: junit fix2

776b9a2

CSTACKEX-18_2: ensure that ONTAP volume related calls are served by c…

c04e223

…ustomized class only.

CSTACKEX-18_2: using flexvolume snapshot to get snapshot workflows fo…

186e59b

…r vm snapshots

CSTACKEX-18_2: using flexvolume snapshot even for CS volume snapshot …

1020a2c

…workflow

CSTACKEX-18_2: we are taking snapshot for volume with flexvolume snap…

672d7a4

…shot with driver orchestrator workflow

CSTACKEX-18_2: junit fixes with recent refactor

9c63c61

CSTACKEX-18_2: fixing snapshot delete condition fix

79730ed

CSTACKEX-18_2: delete snapshot should be done over plugin path not on…

ae96e9b

… agent path

CSTACKEX-18_2: plugin has to consider VM for snapshot in running and …

1b0bba9

…stopped state both.

CSTACKEX-18_2: revert snapshot fixes for API not found

7780a93

CSTACKEC-18_2: revertsnapshot workflow using private cli REST endpoint

5bff41f

CSTACKEX-18_2: taking snapshot with memory option set as true

2abbed6

CSTACKEX-18_2: add exception handling for any error coming from agent

2340400

CSTACKEX-18_2: reverting memory snapshot workflow and eroring out for…

ce93705

… now

CSTACKEX-18_2: revert of memory snapshot implementation

e1a6465

CSTACKEX-18_2: rollback the object creation in case of failures

9138e20

CSTACKEX-18_2: rollback in case of any failures

5f9e51c

piyush5netapp reviewed Mar 9, 2026

View reviewed changes

suryag1201 reviewed Mar 9, 2026

View reviewed changes

sandeeplocharla reviewed Mar 9, 2026

View reviewed changes

rajiv-jain-netapp added 3 commits March 9, 2026 13:53

CSTACKEX-18_2: comments and some changes

142e0e6

CSTACKEX-18_2: checkstyle fixes

aa74a5a

CSTACKEX-18_2: junit fixes

55447b7

piyush5netapp approved these changes Mar 9, 2026

View reviewed changes

rajiv-jain-netapp merged commit fccaf83 into main Mar 9, 2026
16 checks passed

rajiv-jain-netapp deleted the feature/CSTACKEX-18_2 branch March 9, 2026 11:02


		String fileSnapshotName = volumeInfo.getName() + "-" + snapshot.getUuid();

		int maxSnapshotNameLength = 64;


		updateSnapshotDetails(snapshot.getId(), volumeInfo.getId(), poolDetails.get(Constants.VOLUME_UUID), cloneCloudStackVolume.getFile().getPath(), volumeVO.getPoolId(), fileSize);

		snapshotObjectTo.setPath(Constants.ONTAP_SNAP_ID +"="+cloneCloudStackVolume.getFile().getPath());

                       }
                   }
+                  /**

Conversation

rajiv-jain-netapp commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

rajiv-jain-netapp commented Feb 20, 2026

Uh oh!

rajiv-jain-netapp commented Feb 21, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rajiv-jain-netapp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rajiv-jain-netapp commented Feb 20, 2026 •

edited

Loading